Finding resources for programming with VBA in GIS is a challenging task.  I have search high and low, and still I have founnd very little resources.  Here is what I have found so far:

1. ArcScripts

This the best place to find code.  Since it is maintained by ESRI, there is no larger collected anywhere online.  The GIS community uplaods various scripts and the site puts them in an easy to search format.  Many programming languages are available.

Here are a few of my favorite:

Spell Check

Add Text Elements to Layout

2. ESRI Support Center User Forums

The ESRI Support Center User Forums has some great coding resources.  Users post their coding problems and other users respond to their problems.  Usually, the final output is a completed block of code that anyone can use.  This link takes you to the most recent posts for VBA.  You can also search the forums for the code that you need.  Including VBA will provide you with better returns.

3. Customizing ArcGIS Desktop with VBA

The ESRI Resource Center is great site to find a good bit of information for programming with VBA.  Although it corresponds with the ArcGIS 9.3 release, there are some excellent benefits that apply to earlier versions.

4. Utah GIS Portal

The Utah GIS Partal is a hidden wealth of information.  Although it does not provide the smae number of scripts the the ESRI website does, it does have some good samples.  In addition to VBA, it also provides code for Python and C#.  Search the other areas of this site to find more GIS resources.

If you know of any good sites, please let me know so that I can update this list.